Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add default_platform to AKS test #1059

Merged
merged 3 commits into from
Dec 10, 2024
Merged

ci: add default_platform to AKS test #1059

merged 3 commits into from
Dec 10, 2024

Conversation

burgerdev
Copy link
Contributor

No description provided.

@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Dec 9, 2024
@burgerdev burgerdev requested a review from 3u13r December 9, 2024 08:18
3u13r and others added 3 commits December 9, 2024 18:33
Before, when another pod was deployed into the same namespace because of our logging architecture in the CI, the test failed.
@burgerdev
Copy link
Contributor Author

@3u13r: Thanks for debugging this! I changed your commit to use the PodsFromDeployment built into contrasttest, that makes it a little more concise.

@burgerdev burgerdev requested a review from 3u13r December 9, 2024 17:36
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev merged commit cd632ea into main Dec 10, 2024
11 checks passed
@burgerdev burgerdev deleted the burgerdev/fix-e2es branch December 10, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants