Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-image: allow remount service to manage /run #1062

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Dec 10, 2024

We're configuring a tmpfs with 50% of the VMs memory capacity in kata.nix, but this configuration is only applied by systemd-remount-fs.service, which we thus need to enable. That service tries to remount all filesystems, though, so we need to define them correctly in the first place so that they can be remounted. In our case, that meant defining the / mount as read-only.

This fixes the regression test failures on main: https://github.com/edgelesssys/contrast/actions/runs/12250498650.

We're configuring a tmpfs with 50% of the VMs memory capacity in
kata.nix, but this configuration is only applied by
systemd-remount-fs.service, which we thus need to enable. That service
tries to remount all filesystems, though, so we need to define them
correctly in the first place so that they can be remounted. In our case,
that meant defining the / mount as read-only.
@burgerdev burgerdev requested a review from msanft December 10, 2024 05:47
@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Dec 10, 2024
Copy link
Contributor

@msanft msanft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@burgerdev burgerdev merged commit 66c1187 into main Dec 10, 2024
14 of 15 checks passed
@burgerdev burgerdev deleted the burgerdev/run-tmpfs-run branch December 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants