Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attestation: add name to Validator as unique identifier #1095

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jmxnzo
Copy link
Contributor

@jmxnzo jmxnzo commented Dec 19, 2024

This PR is a follow-up on #1027 and aims to enhance the logging of the different validation processes on the coordinator to reach better readability of the logs.

  • Name was introduced as unique identifier in Validator struct and mapping to manifest.json, following the naming convention:
    <attestation>-<reference-values-index>[-<product>]
    The index corresponds to the position of the reference value separated by attestation type in manifest.json.
  • It was ensured that if all validators fail, the joined error message is printed and the formatting was reworked for readability.
  • Single validation failures are printed on DEBUG only instead of ERROR level using the validator name and nonce.

@jmxnzo jmxnzo added the no changelog PRs not listed in the release notes label Dec 19, 2024
@jmxnzo jmxnzo force-pushed the logging/attestation-jla branch from c5805b5 to dde0de0 Compare December 20, 2024 09:22
@jmxnzo jmxnzo changed the title attestation: add name to Validator as unique identifier and attestation: add name to Validator as unique identifier Dec 20, 2024
@jmxnzo jmxnzo force-pushed the logging/attestation-jla branch from dde0de0 to e243f98 Compare December 20, 2024 09:52
@jmxnzo
Copy link
Contributor Author

jmxnzo commented Dec 20, 2024

Wait for merge of #1082

coordinator/internal/authority/credentials.go Outdated Show resolved Hide resolved
coordinator/internal/authority/credentials.go Outdated Show resolved Hide resolved
internal/atls/atls.go Outdated Show resolved Hide resolved
internal/atls/atls.go Outdated Show resolved Hide resolved
internal/attestation/snp/validator.go Outdated Show resolved Hide resolved
sdk/common.go Outdated Show resolved Hide resolved
@jmxnzo jmxnzo requested a review from burgerdev December 23, 2024 13:24
internal/atls/atls.go Outdated Show resolved Hide resolved
internal/atls/atls.go Outdated Show resolved Hide resolved
@jmxnzo jmxnzo requested a review from katexochen December 30, 2024 09:20
@jmxnzo jmxnzo force-pushed the logging/attestation-jla branch from ac3c9b1 to 2092a34 Compare December 30, 2024 09:57
@jmxnzo jmxnzo merged commit 4e7c967 into main Jan 2, 2025
10 checks passed
@jmxnzo jmxnzo deleted the logging/attestation-jla branch January 2, 2025 09:11
@katexochen katexochen added changelog PRs that should be part of the release notes and removed no changelog PRs not listed in the release notes labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog PRs that should be part of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants