-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attestation: add name to Validator as unique identifier #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
December 20, 2024 09:22
c5805b5
to
dde0de0
Compare
jmxnzo
changed the title
attestation: add name to Validator as unique identifier and
attestation: add name to Validator as unique identifier
Dec 20, 2024
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
December 20, 2024 09:52
dde0de0
to
e243f98
Compare
Wait for merge of #1082 |
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
December 20, 2024 10:01
e243f98
to
98e66b7
Compare
burgerdev
reviewed
Dec 20, 2024
burgerdev
reviewed
Dec 20, 2024
katexochen
reviewed
Dec 23, 2024
jmxnzo
force-pushed
the
logging/attestation-jla
branch
from
December 30, 2024 09:57
ac3c9b1
to
2092a34
Compare
burgerdev
approved these changes
Jan 2, 2025
katexochen
added
changelog
PRs that should be part of the release notes
and removed
no changelog
PRs not listed in the release notes
labels
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #1027 and aims to enhance the logging of the different validation processes on the coordinator to reach better readability of the logs.
<attestation>-<reference-values-index>[-<product>]
The index corresponds to the position of the reference value separated by attestation type in manifest.json.