Revert "e2e: remove skip-undeploy flag and go cleanup logic"
#1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 213a7e5. The release test action does not have a cleanup step, and implementing one would be difficult because it uses the default namespace which we can't just delete. Instead, we add the skip-undeploy flag again, flip its default so that most tests are not cleaned up from go and add the flag to the release e2e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 213a7e5.
The release test action does not have a cleanup step, and implementing one would be difficult because it uses the default namespace which we can't just delete. Instead, we add the skip-undeploy flag again, flip its default so that most tests are not cleaned up from go and add the flag to the release e2e.