nodeinstaller: add nydus-pull container #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
reviewed
Dec 23, 2024
katexochen
added
changelog
davidweisse
force-pushed
the
dav/nydus-ctr-pull
branch
from
ee03339 to
c686eae
Compare
burgerdev
reviewed
Jan 7, 2025
katexochen
reviewed
Jan 9, 2025
katexochen
reviewed
Jan 9, 2025
katexochen
reviewed
Jan 9, 2025
|
Please remember to ping devs so they can make the new image public in their registry. |
davidweisse
force-pushed
the
dav/nydus-ctr-pull
branch
from
c686eae to
a0ef8db
Compare
burgerdev
approved these changes
Jan 13, 2025
katexochen
reviewed
Jan 13, 2025
davidweisse
force-pushed
the
dav/nydus-ctr-pull
branch
from
a0ef8db to
e674175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
nydus-pullcontainer, which is running inside the Node Installer as a workaround for thecontainerdbug described in containerd/containerd#8674. When using different snapshotters, such as thenydus-snapshotter, it may happen that some layers were previously pulled using K8s default snapshotter which can then cause the pod to run into this error.The
nydus-pullcontainer watches for all pod events and tries to manually pull failing images that are likely to be caused by this bug. We saw this previously in the regression E2E tests on bare metal, specifically with the redis container.A successful run of the regression test can be found here: https://github.com/edgelesssys/contrast/actions/runs/12745494675
First, the
rediscontainer gets aCreateContainerError, which is then caught by thenydus-pullcontainer. On the next backoff, the container starts normally.