Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: allow usage of different PatchManifestFunc + add test for equal WorkloadSecretID #1104

Merged
merged 2 commits into from
Jan 2, 2025
Merged

e2e: allow usage of different PatchManifestFunc + add test for equal WorkloadSecretID #1104

merged 2 commits into from
Jan 2, 2025
+84 −37

Conversation

jmxnzo
Copy link
Contributor

@jmxnzo jmxnzo commented Dec 23, 2024 •
edited
Loading

This PR introduces the patchManifest() method in contrasttest.go to allow executing PatchManifestFunc on the current manifest, which obtain different modifications.

  • type PatchManifestFunc was introduced to allow using modification functions on the current manifest.
  • existing patchReferenceValues (implements patchManifestFunc) was reduced to the modifcations of the reference values.
  • patchWorkloadSecretID (implements patchManifestFunc) was added to allow overwriting a certain workload secret.
  • a workload secret test case was added, to check that setting the same WorkloadSecretID in two different deployments will result in the identical contrast-secrets.

@jmxnzo jmxnzo added the no changelog PRs not listed in the release notes label Dec 23, 2024
@jmxnzo jmxnzo force-pushed the e2e/workload-secrets-jla branch from 9f01b81 to 379e448 Compare December 23, 2024 19:51
@jmxnzo jmxnzo changed the title e2e: allow usage of multiple PatchManifestFunc + test equal WorkloadSecretID e2e: allow usage of different PatchManifestFunc + test equal WorkloadSecretID Dec 23, 2024
@jmxnzo jmxnzo changed the title e2e: allow usage of different PatchManifestFunc + test equal WorkloadSecretID e2e: allow usage of different PatchManifestFunc + add test for equal WorkloadSecretID Dec 23, 2024
@jmxnzo jmxnzo force-pushed the e2e/workload-secrets-jla branch from 33f9ce4 to 7436ceb Compare December 30, 2024 09:41
@jmxnzo jmxnzo marked this pull request as ready for review December 30, 2024 13:11
@jmxnzo jmxnzo requested a review from burgerdev as a code owner December 30, 2024 13:11
burgerdev
burgerdev approved these changes Jan 2, 2025
View reviewed changes
e2e/internal/contrasttest/contrasttest.go Outdated Show resolved Hide resolved
e2e/internal/contrasttest/contrasttest.go Show resolved Hide resolved
@jmxnzo jmxnzo force-pushed the e2e/workload-secrets-jla branch from 445fc19 to cb9dc2a Compare January 2, 2025 11:47
@jmxnzo jmxnzo force-pushed the e2e/workload-secrets-jla branch from cb9dc2a to 17b580a Compare January 2, 2025 12:26
@jmxnzo jmxnzo merged commit 3e830c4 into main Jan 2, 2025
10 checks passed
@jmxnzo jmxnzo deleted the e2e/workload-secrets-jla branch January 2, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen left review comments

@burgerdev burgerdev burgerdev approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmxnzo @burgerdev @katexochen