Expand coordinator store interface #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Feb 24, 2025
davidweisse
force-pushed
the
dav/expand-store-interface
branch
2 times, most recently
from
17306cb to
9058b96
Compare
burgerdev
approved these changes
Feb 25, 2025
katexochen
reviewed
Feb 25, 2025
davidweisse
force-pushed
the
dav/expand-store-interface
branch
from
9058b96 to
7c1ba5d
Compare
burgerdev
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
Watch()function to theStoreinterface of the Coordinator. This function returns a channel which receives updates to the store, and a cancel function which can be used to stop watching.The
NewStore()method is separated and brought to a new file, so it can be controlled via aenterprisebuild tag.