nix: minify genpolicy binary size #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should be definitely using this for release. However, please note that this results in cryptic and totally unusable errors on genpolicy failures (which occur quite often). |
On the other hand, it makes remote nix builds super slow, since I need to download 150M on every trivial cli change. |
katexochen
approved these changes
Feb 1, 2024
malt3
force-pushed
the
feat/genpolicy-size
branch
from
d072823 to
c5a0712
Compare
Since we are embedding the genpolicy tool as part of the nunki cli, it is desirable to make the binary size smaller. This change takes the size from ~152M down to ~18M.
malt3
force-pushed
the
feat/genpolicy-size
branch
from
c5a0712 to
325b380
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are embedding the genpolicy tool as part of the nunki cli, it is desirable to make the binary size smaller. This change takes the size from ~152M down to ~18M.