cli: only print to stdout if it is a tty #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidweisse
force-pushed
the
dav/cli-discard-stdout
branch
2 times, most recently
from
4663d42 to
6b09535
Compare
davidweisse
force-pushed
the
dav/cli-discard-stdout
branch
from
6b09535 to
8aa07c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, user-friendly messages during CLI commands like
✔️ Generated workload policy annotationsare only printed if a terminal is connected. This way, the output of, e.g.,contrast generatecan be piped directly tokubectl apply:contrast generate -o /dev/stdout | kubectl apply -f -