atls: improve logging #1283
Open
atls: improve logging #1283
+50
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3u13r
requested review from
katexochen and
burgerdev
and removed request for
burgerdev
burgerdev
approved these changes
Mar 11, 2025
| @@ -66,6 +75,7 @@ func (c *Credentials) ServerHandshake(rawConn net.Conn) (net.Conn, credentials.A | |||
|
|
|||
| conn := tls.Server(rawConn, serverCfg) | |||
| if err := conn.HandshakeContext(ctx); err != nil { | |||
| c.logger.DebugContext(ctx, "Handshake error", "error", err) | |||
There was a problem hiding this comment.
Why is this Debug and not Error?
There was a problem hiding this comment.
Because you get a EOF error here every 5 seconds due to the readiness check. Example message:
time=2025-03-11T12:00:20.766Z level=DEBUG msg="Handshake error" atlscredentials.error=EOF
Since this is also confusing for the user when enabling debug logs, we might want to add an explainer in the message or omit EOFs. Though the second one has a obvious downside of also missing all other EOF errors. Any preference?
3u13r
force-pushed
the
euler/feat/atlscredetials-logging
branch
from
972e962 to
3e4f6e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During debugging of the latest SNI issue I had to add more logging in my dev state. It would be best if customers could enable this without code changes to make debugging easier.