Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: secure SetManifest endpoint #131

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Feb 6, 2024

No description provided.

@malt3 malt3 requested a review from katexochen as a code owner February 6, 2024 12:59
@malt3 malt3 requested review from burgerdev and 3u13r February 6, 2024 12:59
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the rfc/002-secure-set-manifest-endpoint branch 2 times, most recently from 8b7c15c to 00b57ce Compare February 6, 2024 17:00
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
rfc/002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
rfc/002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the rfc/002-secure-set-manifest-endpoint branch from 00b57ce to 48e2b0b Compare February 6, 2024 17:27
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

rfc/002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
rfc/002-secure-set-manifest-endpoint.md Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the rfc/002-secure-set-manifest-endpoint branch from 48e2b0b to d517460 Compare February 7, 2024 16:05
@malt3 malt3 requested a review from 3u13r February 7, 2024 16:05
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malt3 malt3 merged commit 4dacdc7 into main Feb 7, 2024
5 checks passed
@malt3 malt3 deleted the rfc/002-secure-set-manifest-endpoint branch February 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants