Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emojivoto deployment using nunki TLS certificates #15

Merged
merged 11 commits into from
Dec 19, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Dec 19, 2023

This PR adds emojivoto (with some minor custom changes) as a deployment. See: https://github.com/3u13r/emojivoto/tree/coco

You can try it out by running

just default emojivoto

If you want to access the web-svc with your browser, add a port-forward to the port-forwarder-2 on port 8080. Also, take a look at the certificates, those are the ones issued by the coordinator.

@3u13r 3u13r requested a review from katexochen as a code owner December 19, 2023 12:00
@3u13r 3u13r force-pushed the feat/tls/add-emojivoto-deployment branch from f214598 to 4a9bca3 Compare December 19, 2023 12:03
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only some nits

internal/ca/ca.go Show resolved Hide resolved
treefmt.nix Outdated Show resolved Hide resolved
cli/generate.go Show resolved Hide resolved
cli/generate.go Outdated Show resolved Hide resolved
internal/ca/ca.go Outdated Show resolved Hide resolved
deployments/emojivoto/coordinator.yml Outdated Show resolved Hide resolved
deployments/emojivoto/initializer.yml Outdated Show resolved Hide resolved
@3u13r 3u13r force-pushed the feat/tls/add-emojivoto-deployment branch from 4a9bca3 to 991debd Compare December 19, 2023 14:27
@3u13r 3u13r requested a review from katexochen December 19, 2023 14:27
@3u13r 3u13r merged commit 84ae9cd into main Dec 19, 2023
2 checks passed
@3u13r 3u13r deleted the feat/tls/add-emojivoto-deployment branch December 19, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants