Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-docs: policy #174

Merged
merged 1 commit into from
Mar 13, 2024
Merged

dev-docs: policy #174

merged 1 commit into from
Mar 13, 2024

Conversation

burgerdev
Copy link
Contributor

I started a write-up of how Kata policies work and what problems I think need addressing.

@burgerdev burgerdev force-pushed the burgerdev/policy-shortcomings branch from c07cd8d to ca6cb3c Compare March 7, 2024 11:14
@burgerdev burgerdev requested review from malt3 and removed request for flxflx, m1ghtym0 and thomasten March 7, 2024 11:14
@burgerdev burgerdev marked this pull request as ready for review March 7, 2024 11:14
@burgerdev
Copy link
Contributor Author

I'd say this is ready for review overall, the part about ConfigMaps can remain open for now because it requires some more investigation.

@burgerdev burgerdev force-pushed the burgerdev/policy-shortcomings branch from ca6cb3c to cd7f2e5 Compare March 7, 2024 11:53
@katexochen katexochen added the no changelog PRs not listed in the release notes label Mar 12, 2024
@malt3
Copy link
Contributor

malt3 commented Mar 13, 2024

nit: s/nunki/contrast/g

Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks!

Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev force-pushed the burgerdev/policy-shortcomings branch from cd7f2e5 to dfaa58c Compare March 13, 2024 18:49
@burgerdev burgerdev merged commit b1f5102 into main Mar 13, 2024
7 checks passed
@burgerdev burgerdev deleted the burgerdev/policy-shortcomings branch March 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants