e2e: generate deployment yaml #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
burgerdev
approved these changes
Mar 4, 2024
Comment on lines
+10
to
+13
| coordinatorForwarder := PortForwarder("coordinator", ns). | ||
| WithListenPort(1313). | ||
| WithForwardTarget("coordinator", 1313). | ||
| PodApplyConfiguration |
There was a problem hiding this comment.
I wonder whether the portforwarder pod should even be part of this bundle, because it's only useful for the corresponding exposure logic in kubeclient I'm implementing in #185.
There was a problem hiding this comment.
For now, this is just to fulfill the interface with our current workflow. As we previously discussed, it is unclear if the sets will be called by the e2e at all, or if the e2e tests will just construct their own individual set.
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to generate the yaml for the tests etc instead of keeping a lot of yaml laying around in-tree. This shifts the source of truth into the Go code. This PR implements a first small step, generating the simple deployment. Patching is still done in the justfile using kypatch.