coordinator: align mesh root naming #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3u13r
force-pushed
the
fix/return-mesh-root-on-verify
branch
from
6a58dad to
aa92c89
Compare
This also fixes a bug where the intermediate cert is returned and saved as "mesh-root.pem".
3u13r
force-pushed
the
fix/return-mesh-root-on-verify
branch
from
aa92c89 to
15ea885
Compare
katexochen
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a bug where the intermediate cert is returned and saved as "mesh-root.pem".
I think now the naming is coherent. If you have suggestion for a different naming scheme, we should settle on that before we need to compatibility regarding upgrades.