Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: return stdout/stderr even on exec failure #246

Merged
merged 1 commit into from
Mar 14, 2024
Merged

e2e: return stdout/stderr even on exec failure #246

merged 1 commit into from
Mar 14, 2024

Conversation

burgerdev
Copy link
Contributor

The exec call returns an error if the remote command had a non-zero return code, which is when access to the output is most important.

@burgerdev
e2e: return stdout/stderr even on exec failure
2072414 
The exec call returns an error if the remote command had a non-zero
return code, which is when access to the output is most important.
@burgerdev burgerdev requested a review from malt3 March 13, 2024 13:54
@burgerdev burgerdev requested a review from katexochen as a code owner March 13, 2024 13:54
@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Mar 13, 2024
@burgerdev burgerdev mentioned this pull request Mar 13, 2024
Closed
@burgerdev burgerdev merged commit c381f3c into main Mar 14, 2024
8 checks passed
@burgerdev burgerdev deleted the burgerdev/kubeclient-exec-stdout branch March 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@malt3 malt3 Awaiting requested review from malt3

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerdev @katexochen