Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igvmmeasure: package #254

Merged
merged 1 commit into from
Mar 18, 2024
Merged

igvmmeasure: package #254

merged 1 commit into from
Mar 18, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Mar 15, 2024

Note: we will probably use this upstream implementation instead of the custom implementation that was in this PR before, since we can avoid maintenance costs: coconut-svsm/svsm#294

This tool can be used to precalculate the SNP launch digest of a VM given an IGVM file.

Example:

$ igvmmeasure kata-containers-igvm.img
4a7cb0294cbeeb2dae9cad42ba97e91133f929da970aa211119389f59bc9e2560f936ecce92cbd55f03ab3c019afd591

@malt3 malt3 added the feature Shiny new feature for our users label Mar 15, 2024
@malt3 malt3 force-pushed the feat/launch-digest-tool branch from 87a259e to ff7158a Compare March 18, 2024 10:16
@malt3 malt3 changed the title precalculate-launch-digest: initialize igvmmeasure: package Mar 18, 2024
This tool can be used to precalculate the SNP launch digest of a VM given
an IGVM file.
@malt3 malt3 force-pushed the feat/launch-digest-tool branch from ff7158a to b9d8244 Compare March 18, 2024 10:18
@katexochen katexochen added no changelog PRs not listed in the release notes and removed feature Shiny new feature for our users labels Mar 18, 2024
@katexochen
Copy link
Member

Not a feature, as no user facing change.

@malt3 malt3 marked this pull request as ready for review March 18, 2024 10:42
@malt3 malt3 requested a review from katexochen as a code owner March 18, 2024 10:42
@malt3 malt3 merged commit 4cc7026 into main Mar 18, 2024
9 checks passed
@malt3 malt3 deleted the feat/launch-digest-tool branch March 18, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants