cli: don't allow empty coordinator policy hash #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
force-pushed
the
burgerdev/no-empty-policy-hash
branch
from
1da77f2 to
879d524
Compare
burgerdev
force-pushed
the
burgerdev/no-empty-policy-hash
branch
from
879d524 to
501a8c9
Compare
katexochen
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contrastused to allow setting an empty coordinator policy hash on the command-line, which resulted in the policy hash not being checked at all. This was intended as a development feature, but the chances of accidental misuse are too high, thus we're requiring a policy hash to be present. It's still possible to accept untrusted policies by overriding with the actual hash of the deployed coordinator without verifying it.