Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/cmd: fix writeFileList error when dir is empty #285

Merged
merged 1 commit into from
Mar 28, 2024
Merged

cli/cmd: fix writeFileList error when dir is empty #285

merged 1 commit into from
Mar 28, 2024

Conversation

katexochen
Copy link
Member

Previously, the set command would fail if no workspace-dir was explicitly specified, as mkdir fails on empty argument.

@katexochen katexochen added the bug fix Fixing a user facing bug label Mar 28, 2024
@katexochen katexochen requested review from burgerdev and msanft March 28, 2024 08:46
@katexochen katexochen merged commit c5aa729 into main Mar 28, 2024
7 of 8 checks passed
@katexochen katexochen deleted the p/filelist-mkdir branch March 28, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

@burgerdev burgerdev Awaiting requested review from burgerdev

Assignees
No one assigned
Labels
bug fix Fixing a user facing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katexochen @msanft