Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: added emojivoto resource generation function #290

Merged
merged 1 commit into from
Apr 5, 2024
Merged

e2e: added emojivoto resource generation function #290

merged 1 commit into from
Apr 5, 2024

Conversation

wirungu
Copy link
Contributor

@wirungu wirungu commented Apr 2, 2024 •
edited
Loading

Added Emojivoto resource generation code. Minor differences between the generated and original deployment. See attached dyff for details.
dyff.txt

@wirungu wirungu requested a review from katexochen as a code owner April 2, 2024 09:59
@wirungu wirungu changed the title e2e: added emojivoto resource generation e2e: added emojivoto resource generation function Apr 2, 2024
@wirungu wirungu added the no changelog PRs not listed in the release notes label Apr 2, 2024
@katexochen
Copy link
Member

katexochen commented Apr 2, 2024 •
edited
Loading

Thanks! I think the following points from the diff should be fixed, the remaining diff looks ok:

spec.selector  (Service/edg-default/emoji-svc)
  + one map entry added:
    version: v11

spec.selector  (Service/edg-default/voting-svc)
  + one map entry added:
    version: v11

@wirungu
Copy link
Contributor Author

wirungu commented Apr 2, 2024 •
edited
Loading

Here's the updated diff:
dyff.txt

@wirungu wirungu marked this pull request as draft April 3, 2024 07:37
@wirungu wirungu marked this pull request as ready for review April 3, 2024 08:56
@wirungu wirungu force-pushed the mi/e2e-emojivoto branch from 212f6de to e697352 Compare April 4, 2024 11:52
@wirungu wirungu force-pushed the mi/e2e-emojivoto branch from e697352 to d41f131 Compare April 4, 2024 14:23
@wirungu wirungu merged commit 56adc35 into main Apr 5, 2024
7 checks passed
@wirungu wirungu deleted the mi/e2e-emojivoto branch April 5, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wirungu @katexochen