-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: create efficient oci images with reusable layers #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only reviewd the ociLayer file in detail.
I think adding a README with some documentation would be nice. Maybe we can add it to the top level function and link it into the other pkgs?
8f2429e
to
b71253d
Compare
|
4b3468c
to
96161b5
Compare
96161b5
to
15c5fd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Is there any easy way to add a test for this?
15c5fd2
to
c6f2050
Compare
I think the best real test case will be the node installer image. We could also add a dummy image with expected file contents. Would that be preferred as part of this PR? |
This set of functions generates layers that can be combined into OCI image layout directories. Those can directly be pushed to a registry. Strong focus was placed on making the layers reusable in arbitrary ways. This allows for efficient distribution of binary artifacts via container image layers.
c6f2050
to
892eed2
Compare
Likely you're right and having it in our end-to-end flow is enough. I thought about a simple test creating an image and running it with docker or so just to see it is valid. But not strictly necessary. |
Maybe using a file format validator could be enough of a test? https://github.com/opencontainers/image-tools/blob/master/man/oci-image-tool-validate.1.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This set of functions generates layers that can be combined into OCI image layout directories. Those can directly be pushed to a registry.
Strong focus was placed on making the layers reusable in arbitrary ways. This allows for efficient distribution of binary artifacts via container image layers.
Feel free to suggest a different layout in nix!