Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add emojivotodemo #301

Closed
wants to merge 12 commits into from
Closed

e2e: add emojivotodemo #301

wants to merge 12 commits into from

Conversation

wirungu
Copy link
Contributor

@wirungu wirungu commented Apr 5, 2024

Added an EmojivotoDemo function generating the specific deployment here. Here is a diff between the generated files and the original.

   _| |_   _ / _|/ _|  between leo.yml, twelve documents
 / _' | | | | |_| |_       and generated.yml, twelve documents
| (_| | |_| |  _|  _|
 \__,_|\__, |_| |_|   returned six differences
        |___/

(file level)
  ⇆ order changed
    v1/ServiceAccount/default/emoji               apps/v1/Deployment/default/emoji
    apps/v1/Deployment/default/emoji              v1/Service/default/emoji-svc
    v1/Service/default/emoji-svc                  v1/ServiceAccount/default/emoji
    v1/Pod/default/port-forwarder-coordinator     v1/Pod/default/port-forwarder-coordinator
    v1/Pod/default/port-forwarder-emojivoto-web   v1/Pod/default/port-forwarder-emojivoto-web
    apps/v1/Deployment/default/vote-bot           apps/v1/Deployment/default/vote-bot
    v1/ServiceAccount/default/voting              apps/v1/Deployment/default/voting
    apps/v1/Deployment/default/voting             v1/Service/default/voting-svc
    v1/Service/default/voting-svc                 v1/ServiceAccount/default/voting
    v1/ServiceAccount/default/web                 apps/v1/Deployment/default/web
    apps/v1/Deployment/default/web                v1/Service/default/web-svc
    v1/Service/default/web-svc                    v1/ServiceAccount/default/web

spec.template.spec.containers.emoji-svc.resources.requests  (apps/v1/Deployment/default/emoji)
  - one map entry removed:
    cpu: 100m

spec.template.spec.containers.vote-bot.resources.requests  (apps/v1/Deployment/default/vote-bot)
  - one map entry removed:
    cpu: 10m

spec.template.spec.containers.voting-svc.resources.requests  (apps/v1/Deployment/default/voting)
  - one map entry removed:
    cpu: 100m

spec.template.spec.initContainers.initializer  (apps/v1/Deployment/default/web)
  + one map entry added:
    resources:
      limits:
        memory: 50Mi
      requests:
        memory: 50Mi

spec.template.spec.containers.web-svc.resources.requests  (apps/v1/Deployment/default/web)
  - one map entry removed:
    cpu: 100m

@wirungu wirungu added the no changelog PRs not listed in the release notes label Apr 8, 2024
@wirungu wirungu marked this pull request as ready for review April 8, 2024 07:30
@wirungu wirungu requested a review from katexochen as a code owner April 8, 2024 07:30
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@wirungu wirungu marked this pull request as draft April 8, 2024 07:43
@wirungu wirungu requested review from burgerdev and katexochen April 10, 2024 12:45
@wirungu wirungu marked this pull request as ready for review April 10, 2024 14:13
@wirungu wirungu marked this pull request as draft April 10, 2024 16:19
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks like you only need to revert GenerateEmojivoto to not take arguments.

e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
@wirungu wirungu marked this pull request as ready for review April 12, 2024 10:44
@katexochen
Copy link
Member

Please clean up the commit history before merge.

e2e/internal/kuberesource/sets.go Outdated Show resolved Hide resolved
e2e/internal/kuberesource/sets.go Show resolved Hide resolved
@wirungu wirungu force-pushed the mi/e2e-emojivotodemo branch from 8ef3e78 to 79a68ff Compare April 12, 2024 13:15
@wirungu wirungu closed this Apr 15, 2024
@wirungu wirungu deleted the mi/e2e-emojivotodemo branch April 16, 2024 09:17
@wirungu wirungu restored the mi/e2e-emojivotodemo branch April 16, 2024 09:17
@wirungu wirungu deleted the mi/e2e-emojivotodemo branch April 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants