Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: remove duplicate port forwarder in OpenSSL() #315

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

burgerdev
Copy link
Contributor

This was the reason for errors like https://github.com/edgelesssys/contrast/actions/runs/8630436934/job/23656688314#step:14:78 - apply ends up creating only one pod, but delete attempts to delete the pod twice, while the second attempt fails.

@burgerdev burgerdev requested a review from wirungu April 10, 2024 12:55
@burgerdev burgerdev requested a review from katexochen as a code owner April 10, 2024 12:55
@katexochen katexochen added the no changelog PRs not listed in the release notes label Apr 10, 2024
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🐳

Copy link
Contributor

@wirungu wirungu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!

@burgerdev burgerdev merged commit 5ca9df2 into main Apr 10, 2024
7 of 8 checks passed
@burgerdev burgerdev deleted the burgerdev/ignore-404 branch April 10, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants