Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add site about certificates #324

Merged
merged 1 commit into from
Apr 28, 2024
Merged

docs: add site about certificates #324

merged 1 commit into from
Apr 28, 2024

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Apr 13, 2024

Document how the Coordinator acts as certificate authority, how cert chains are structured and how certificate rotation works. Also describe how the different certificates can be used for different use cases.

@3u13r 3u13r requested a review from katexochen as a code owner April 13, 2024 18:00
@3u13r 3u13r requested review from burgerdev and m1ghtym0 April 13, 2024 18:01
@3u13r 3u13r added the documentation Improvements for user docs label Apr 13, 2024
@3u13r 3u13r force-pushed the feat/docs/pki-first-draft branch from 3c1fbaf to b8a191d Compare April 13, 2024 18:04
Copy link

github-actions bot commented Apr 13, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-28 14:14 UTC

@3u13r 3u13r force-pushed the feat/docs/pki-first-draft branch from b8a191d to e8d219d Compare April 18, 2024 16:58
@3u13r 3u13r requested review from katexochen and burgerdev April 18, 2024 16:59
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the code changes into a separate PR, these are breaking changes for the user interface.

Also, please re-check the occurrence of mesh.root/meshRoot in the project, there are still plenty of findings. Especially, the constant for the mesh CA cert filename wasn't updated.

@3u13r 3u13r force-pushed the feat/docs/pki-first-draft branch 3 times, most recently from d194dba to d333dfc Compare April 21, 2024 22:30
@3u13r 3u13r requested a review from katexochen April 22, 2024 10:22
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Show resolved Hide resolved
@3u13r 3u13r force-pushed the feat/docs/pki-first-draft branch from d333dfc to 24f82d8 Compare April 25, 2024 21:46
@3u13r 3u13r requested a review from m1ghtym0 April 25, 2024 21:46
@3u13r 3u13r force-pushed the feat/docs/pki-first-draft branch from 24f82d8 to a66eb1b Compare April 25, 2024 22:11
Copy link
Member

@m1ghtym0 m1ghtym0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM.
Please rebase on main, we might need to adjust some references to the new location of this page.

docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
docs/docs/architecture/certificates.md Outdated Show resolved Hide resolved
@3u13r 3u13r force-pushed the feat/docs/pki-first-draft branch from a66eb1b to 85f7e48 Compare April 28, 2024 12:44
@3u13r 3u13r merged commit 1f9af4c into main Apr 28, 2024
6 checks passed
@3u13r 3u13r deleted the feat/docs/pki-first-draft branch April 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements for user docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants