cli: add telemetry wrapper for cli commands #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasten
reviewed
Apr 16, 2024
davidweisse
force-pushed
the
feat/telemetry-cli
branch
from
db49400 to
8dbb867
Compare
thomasten
approved these changes
Apr 17, 2024
davidweisse
force-pushed
the
feat/telemetry-cli
branch
3 times, most recently
from
78787bb to
2e52688
Compare
|
you can use DO_NOT_TRACK instead of hosts file |
davidweisse
force-pushed
the
feat/telemetry-cli
branch
6 times, most recently
from
150d097 to
20baf20
Compare
katexochen
reviewed
Apr 22, 2024
davidweisse
force-pushed
the
feat/telemetry-cli
branch
from
20baf20 to
4b1a55b
Compare
davidweisse
force-pushed
the
feat/telemetry-cli
branch
from
4b1a55b to
f64004c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a wrapper function around the
generate,setandverifycommands to send telemetry to the telemetry server. The processed data currently includes:The error string currently returns "unknown error" for a non-nil error. This can be configured by checking for error types in the future.