-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: adopt contrasttest framework #353
Conversation
fad9f1c
to
bb4d1ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bb4d1ba
to
54bf60b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we want to test both the ingress and the egress separately. Currently, the "ingress" Test/Deployment also contains the egress configuration.
Either we have one (correctly named) test or we split the egress and ingress configuration.
If we choose to go with the second option, we need to configure the deployment similar to third commit of the PR: https://github.com/edgelesssys/contrast/pull/186/commits where the my "3u13r/web" image is used but the microservices use the ingress service mesh.
54bf60b
to
2966a56
Compare
Thank you for clarifying. I opted to rename the configuration to reflect that we are testing ingress and egress together. |
I tried to faithfully copy the small differences I saw between the static deployment files (emojivoto-sm-{in|e}gress) as part of
generateEmojivoto
.@3u13r please confirm if my choices are correct.