Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add test for release candidates #355

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Apr 19, 2024

This is a forward-port of #370, adapting changes to resourcegen on main.

Demo run: https://github.com/edgelesssys/contrast/actions/runs/8941131966

@burgerdev burgerdev force-pushed the burgerdev/e2e-release branch from 06af4a2 to cb8f401 Compare April 19, 2024 12:02
@burgerdev burgerdev added the no changelog PRs not listed in the release notes label Apr 19, 2024
@burgerdev burgerdev force-pushed the burgerdev/e2e-release branch 2 times, most recently from d8edb78 to 9a96e3d Compare April 19, 2024 12:58
@burgerdev burgerdev marked this pull request as ready for review April 19, 2024 12:59
@burgerdev burgerdev requested a review from katexochen as a code owner April 19, 2024 12:59
@burgerdev burgerdev requested a review from malt3 April 19, 2024 12:59
@malt3
Copy link
Contributor

malt3 commented Apr 19, 2024

Code LGTM. How will this be used? Is this a manual step for the release engineer or will you add this to CI?

@burgerdev
Copy link
Contributor Author

I'd say this should be a step in the release pipeline. Might as well add it right away, hang on...

@burgerdev burgerdev changed the title wip: e2e release test e2e: add test for release candidates Apr 19, 2024
@burgerdev burgerdev force-pushed the burgerdev/e2e-release branch from 9a96e3d to 40952c1 Compare April 19, 2024 14:14
@burgerdev burgerdev added the blocked There is something blocking the progress on this one label Apr 19, 2024
@burgerdev
Copy link
Contributor Author

Now we need the demo files to be included into the release.

@burgerdev burgerdev force-pushed the burgerdev/e2e-release branch from 40952c1 to d9beebd Compare April 24, 2024 06:45
@burgerdev burgerdev force-pushed the burgerdev/e2e-release branch 2 times, most recently from 25e8e4d to 8bff4ee Compare May 3, 2024 15:40
@burgerdev burgerdev force-pushed the burgerdev/e2e-release branch from 8bff4ee to e4e8411 Compare May 3, 2024 20:18
@burgerdev burgerdev removed the blocked There is something blocking the progress on this one label May 4, 2024
@burgerdev burgerdev merged commit a657c7b into main May 6, 2024
8 checks passed
@burgerdev burgerdev deleted the burgerdev/e2e-release branch May 6, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants