e2e: add emojivoto to release

[wirungu]

resourcegen now takes an additional argument for the file path containing image patches. The demo generation has been modified to make use of this, though the namespace patching still runs through kypatch for now.

[burgerdev]

Why are these not needed anymore?

[wirungu]

The coordinator gets generated separately. Only the Emojivoto files need to be in the ZIP

[burgerdev]

Point taken about the coordinator, but what about the initializer? It needs to be patched in the demo resources, doesn't it?

@katexochen: demodir is currently a mix between released artifacts and HEAD. What do you think about moving back to "everything from HEAD" when releases include the demo app?

[katexochen]

Why move to HEAD instead of taking everything from the release? The purpose of demodir is to drop a dev into a reliable and stable demo environment.

[burgerdev]

This will be possible with gh release download after the next release, which is why I was thinking to either drop the target (if we only ever want stable demo dirs), or use the dev build to simulate "what we would get if we'd cut a release now".

[wirungu]

I'm also unsure how to complete the release workflow: should steps for installing and calling just be added to .github/workflows/release.yml or should I essentially replicate the nix shell commands from the justfile there?

[burgerdev]

The nix run resourcegen line should go into a step here, followed by zipping it.

contrast/.github/workflows/release.yml

Line 200 in 822dee4

nix run .#scripts.write-coordinator-yaml -- "${coordinatorImgTagged}" > workspace/coordinator.yml

The resulting zip needs to be included into the released files.

contrast/.github/workflows/release.yml

Lines 221 to 223 in 822dee4

	files: |
	result-cli/bin/contrast
	workspace/coordinator.yml

There may be a general misunderstanding here: the demodir target is not supposed to be the basis for release, rather it was a convenient way to obtain both the released artifacts and the demo app with a simple command. As mentioned in the thread, I think demodir in its current form is obsolete when we release emojivoto.

[wirungu]

The nix run resourcegen line should go into a step here, followed by zipping it.

contrast/.github/workflows/release.yml

Line 200 in 822dee4

nix run .#scripts.write-coordinator-yaml -- "${coordinatorImgTagged}" > workspace/coordinator.yml

The resulting zip needs to be included into the released files.

contrast/.github/workflows/release.yml

Lines 221 to 223 in 822dee4

	files: |
	result-cli/bin/contrast
	workspace/coordinator.yml

There may be a general misunderstanding here: the demodir target is not supposed to be the basis for release, rather it was a convenient way to obtain both the released artifacts and the demo app with a simple command. As mentioned in the thread, I think demodir in its current form is obsolete when we release emojivoto.

I have tried to add a similar script to the one currently generating the coordinator in the release. It does not work at the moment and I am trying to understand why

[wirungu]

I believe there is now at least a correctly generated and patched demo being produced in the release, so the E2E release testing can at least proceed. I'm really sorry about the delay.
Some questions:

• Should the initializer also have release tags added?
• Should the demodir target now be removed?

[burgerdev]

Overall lgtm, but the demodir target is still broken afaict. Maybe it would make sense to revert the justfile changes in this PR and focus on the release?

[burgerdev]

I rebased this and fixed the merge conflict with node-installer. Once tests pass, I'll hit merge.