snp: KDS cache garbage collection #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3u13r
force-pushed
the
feat/ca/cache-garbage-collection
branch
from
52e4a59 to
caa4b70
Compare
katexochen
requested changes
Jan 3, 2024
katexochen
reviewed
Jan 3, 2024
3u13r
force-pushed
the
feat/ca/cache-garbage-collection
branch
from
010f4e0 to
df394b1
Compare
3u13r
force-pushed
the
feat/ca/cache-garbage-collection
branch
from
df394b1 to
0132e71
Compare
katexochen
requested changes
Jan 5, 2024
There was a problem hiding this comment.
Looks mostly good to me, some nits.
Also CI isn't quite there yet, following errors are thrown locally:
nix run .#golangci-lint run
internal/attestation/snp/cachedClient.go:19:1 revive exported: exported function NewCachedKDSHTTPClient should have comment or be unexported
internal/memstore/memstore.go:44:1 revive exported: exported method Store.Clear should have comment or be unexported
3c70d9b to
c0d4c04
Compare
3u13r
force-pushed
the
feat/ca/cache-garbage-collection
branch
from
c0d4c04 to
eedb3ec
Compare
katexochen
reviewed
Jan 9, 2024
3u13r
force-pushed
the
feat/ca/cache-garbage-collection
branch
2 times, most recently
from
b018222 to
8358004
Compare
3u13r
force-pushed
the
feat/ca/cache-garbage-collection
branch
from
8358004 to
ec34015
Compare
katexochen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.