Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: patch runtime class name #385

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Apr 25, 2024

To improve the UX and avoid mismatches between the runtime class used by contrast and the runtime class used by customer deployments, we now automatically replace runtimeClassName fields in yaml files during contrast generate.

@malt3 malt3 added the no changelog PRs not listed in the release notes label Apr 25, 2024
@malt3 malt3 force-pushed the feat/generate/patch-runtimeClassName branch 3 times, most recently from c2ef3e4 to 63d76d4 Compare April 25, 2024 14:29
@malt3 malt3 marked this pull request as ready for review April 25, 2024 14:41
@malt3 malt3 requested a review from katexochen as a code owner April 25, 2024 14:41
@malt3 malt3 requested a review from burgerdev April 25, 2024 14:49
cli/cmd/generate.go Outdated Show resolved Hide resolved
cli/cmd/generate.go Outdated Show resolved Hide resolved
internal/kuberesource/mutators.go Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/generate/patch-runtimeClassName branch 3 times, most recently from 0bdf4dd to c419e70 Compare April 26, 2024 07:47
@katexochen katexochen added feature Shiny new feature for our users and removed no changelog PRs not listed in the release notes labels Apr 26, 2024
@malt3 malt3 force-pushed the feat/generate/patch-runtimeClassName branch 3 times, most recently from af455df to a7d4f05 Compare April 26, 2024 11:46
@malt3 malt3 requested a review from katexochen April 26, 2024 12:52
@malt3 malt3 force-pushed the feat/generate/patch-runtimeClassName branch from a7d4f05 to f39973a Compare May 2, 2024 07:15
@malt3 malt3 merged commit ffa4b38 into main May 2, 2024
7 checks passed
@malt3 malt3 deleted the feat/generate/patch-runtimeClassName branch May 2, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Shiny new feature for our users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants