e2e: simplify emojivoto #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
burgerdev
commented
Apr 25, 2024
burgerdev
commented
- Flatten the call hierarchy by removing redundant dispatch.
- Remove the coordinator from Emojivoto target and only add it where necessary (on e2e test). This is necessary so that there is no coordinator in the demo release asset.
|
The current Emojivoto function contains port-forwarders. I think these aren't needed/wanted for the demo, as the demo should come with services of type loadBalancer. Where are we going to handle such differences? |
burgerdev
force-pushed
the
burgerdev/e2e-simplify
branch
from
33fcff2 to
cb1d2fa
Compare
|
This is a follow-up PR, #395 :) |
katexochen
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.