genpolicy: add patch to filter for runtime class #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's give upstream some days to review the upstream PR. |
3u13r
force-pushed
the
feat/genpolicy/runtime-class-filtering
branch
2 times, most recently
from
f76ebd1 to
f7c3802
Compare
3u13r
changed the title
|
Upstream has been merged without additional changes 🎉. |
3u13r
force-pushed
the
feat/genpolicy/runtime-class-filtering
branch
2 times, most recently
from
70e1f9e to
6415dc2
Compare
burgerdev
approved these changes
Jun 5, 2024
| let yaml_contents = yaml::get_input_yaml(&config.yaml_file)?; | ||
|
|
||
| - for document in serde_yaml::Deserializer::from_str(&yaml_contents) { | ||
| + 'doc: for document in serde_yaml::Deserializer::from_str(&yaml_contents) { |
There was a problem hiding this comment.
That label is unused, isn't it?
katexochen
approved these changes
Jun 5, 2024
| @@ -33,6 +33,7 @@ rustPlatform.buildRustPackage rec { | |||
| url = "https://github.com/kata-containers/kata-containers/commit/f61b43777834f097fcca26864ee634125d9266ef.patch"; | |||
| sha256 = "sha256-wBOyrFY4ZdWBjF5bIrHm7CFy6lVclcvwhF85wXpFZoc="; | |||
| }) | |||
| ./genpolicy_msft_runtime_class_filter.patch | |||
There was a problem hiding this comment.
Please create patches with git format-patch from a commit (in the future). Rules and settings patches in this dir are a bad example.
3u13r
force-pushed
the
feat/genpolicy/runtime-class-filtering
branch
from
6415dc2 to
fd4fdea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses kata-containers/kata-containers#9725 adapted so it successfully applies to the msft fork.