cli: inject service mesh with contrast generate
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
burgerdev
reviewed
Jun 6, 2024
davidweisse
force-pushed
the
feat/inject-servicemesh
branch
3 times, most recently
from
1dc6ff1 to
a0b857c
Compare
burgerdev
reviewed
Jun 7, 2024
| return MapPodSpec(resource, func(spec *applycorev1.PodSpecApplyConfiguration) *applycorev1.PodSpecApplyConfiguration { | ||
| ) (res any, retErr error) { | ||
| res = MapPodSpecWithMeta(resource, func(meta *applymetav1.ObjectMetaApplyConfiguration, spec *applycorev1.PodSpecApplyConfiguration) *applycorev1.PodSpecApplyConfiguration { | ||
| if spec.RuntimeClassName == nil || !strings.HasPrefix(*spec.RuntimeClassName, "contrast-cc") { |
There was a problem hiding this comment.
Not for you to fix here, but a general observation: we should make contrast-cc a constant and replace all the string literals.
davidweisse
force-pushed
the
feat/inject-servicemesh
branch
from
a0b857c to
d6937bb
Compare
burgerdev
approved these changes
Jun 10, 2024
katexochen
changed the title
contrast generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service mesh sidecar will be injected to every workload with the
contrast-ccruntime class and a specified Service Mesh configuration. Configuration can be done via object annotations:contrast.edgeless.systems/servicemesh-ingress: Envoy proxy ingress configcontrast.edgeless.systems/servicemesh-egress: Envoy proxy egress configcontrast.edgeless.systems/servicemesh-admin-interface-port: Port for the Envoy admin interfaceThe annotations will be copied to the corresponding environment variables during
generate.