release: publish emojivoto as yml instead of zip #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
davidweisse
force-pushed
the
dav/emojivoto-zip
branch
2 times, most recently
from
6adb926 to
5bd1aab
Compare
burgerdev
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
The change lgtm, but I wonder whether we should just generate all the released yaml with the CLI in the first place. cc @katexochen
katexochen
reviewed
Jun 27, 2024
We have tickets for that, but iirc we decided to postpone implementation. |
davidweisse
force-pushed
the
dav/emojivoto-zip
branch
2 times, most recently
from
81b5b8f to
60ca136
Compare
davidweisse
force-pushed
the
dav/emojivoto-zip
branch
from
60ca136 to
b4eb2b4
Compare
katexochen
approved these changes
Jun 27, 2024
katexochen
added a commit
that referenced
this pull request
Jul 10, 2024
This was re-introduced by mistake when rebasing #652. Originally removed in #640 Signed-off-by: Paul Meyer <[email protected]>
katexochen
added a commit
that referenced
this pull request
Jul 10, 2024
This was re-introduced by mistake when rebasing #652. Originally removed in #640 Signed-off-by: Paul Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the released Emojivoto deployment from a zip file to a single YAML file.