cli: improve UX of set command #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
requested changes
Jan 11, 2024
malt3
force-pushed
the
feat/cli/spinner
branch
2 times, most recently
from
3d6f3be to
8b9ee40
Compare
malt3
force-pushed
the
feat/cli/spinner
branch
from
8b9ee40 to
1eae7c5
Compare
katexochen
reviewed
Jan 11, 2024
malt3
force-pushed
the
feat/cli/spinner
branch
from
1eae7c5 to
776ac98
Compare
katexochen
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a progress indicator and guards the
SetManifestrpc with a retry loop.Note that dialing in grpc is basically a no-op, which means we have to do the retry around the actual client rpc.
While there are grpc options to change this behavior, those are strongly discouraged.