Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: validate seed share owner pubkeys #653

Merged
merged 2 commits into from
Jul 1, 2024
Merged

manifest: validate seed share owner pubkeys #653

merged 2 commits into from
Jul 1, 2024

Conversation

davidweisse
Copy link
Contributor

This tries to parse the seed share owner keys when validating the manifest.

@davidweisse davidweisse added the no changelog PRs not listed in the release notes label Jun 28, 2024
@davidweisse davidweisse requested a review from burgerdev June 28, 2024 15:04
@davidweisse davidweisse requested a review from katexochen as a code owner June 28, 2024 15:04
Freax13
Freax13 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Freax13
manifest: mention invalid key in message
02d873a 
This helps the user figure out which of the keys was invalid.
katexochen
katexochen reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the fixup into the original PR.

@Freax13 Freax13 merged commit 8659343 into main Jul 1, 2024
8 checks passed
@Freax13 Freax13 deleted the dav/manifest-validation branch July 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen left review comments

@Freax13 Freax13 Freax13 approved these changes

@burgerdev burgerdev Awaiting requested review from burgerdev

Assignees

@Freax13 Freax13

Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidweisse @Freax13 @katexochen