Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: create default policy setting file and manifest on generate #66

Merged
merged 1 commit into from
Jan 12, 2024
Merged

cli: create default policy setting file and manifest on generate #66

merged 1 commit into from
Jan 12, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Jan 11, 2024

If files do not exist yet, generate will write default files.

@malt3 malt3 requested a review from katexochen as a code owner January 11, 2024 14:52
@malt3 malt3 force-pushed the feat/generate/create-defaults-if-not-exists branch from d893349 to 8ffa097 Compare January 11, 2024 15:02
katexochen
katexochen requested changes Jan 11, 2024
View reviewed changes
internal/manifest/constants.go Outdated Show resolved Hide resolved
internal/manifest/constants.go Outdated Show resolved Hide resolved
internal/manifest/constants.go Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
data/.gitkeep Outdated Show resolved Hide resolved
cli/generate.go Outdated Show resolved Hide resolved
cli/generate.go Outdated Show resolved Hide resolved
cli/generate.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/generate/create-defaults-if-not-exists branch from 8ffa097 to cc7d9a4 Compare January 11, 2024 17:30
katexochen
katexochen reviewed Jan 11, 2024
View reviewed changes
cli/constants.go Outdated Show resolved Hide resolved
@malt3 malt3 force-pushed the feat/generate/create-defaults-if-not-exists branch 6 times, most recently from 91713da to f31da19 Compare January 11, 2024 18:00
@malt3 malt3 force-pushed the feat/generate/create-defaults-if-not-exists branch from f31da19 to b19ce5a Compare January 12, 2024 08:03
katexochen
katexochen requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, just some nits remaining

cli/generate.go Outdated Show resolved Hide resolved
cli/generate.go Outdated Show resolved Hide resolved
cli/manifest.json Outdated Show resolved Hide resolved
@malt3
cli: create default policy setting file, rego and manifest on generate
7e541b9 
If files do not exist yet, generate will write default files.
@malt3 malt3 force-pushed the feat/generate/create-defaults-if-not-exists branch from b19ce5a to 7e541b9 Compare January 12, 2024 09:29
@malt3 malt3 merged commit d9d3fd4 into main Jan 12, 2024
4 checks passed
@malt3 malt3 deleted the feat/generate/create-defaults-if-not-exists branch January 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malt3 @katexochen