generate: rename --workload-owner-key to --add-workload-owner-key #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
approved these changes
Jul 4, 2024
cli/cmd/generate.go
Outdated
Comment on lines
66
to
67
| cmd.Flags().StringArrayP("add-workload-owner-key", "w", []string{workloadOwnerPEM}, | ||
| "path to workload owner key (.pem) file (can be passed more than once)") |
There was a problem hiding this comment.
The docstring should describe the behavior. Maybe
add a workload owner key from a PEM file to the manifest (pass more than once to add multiple keys)
This makes it more obvious to the user that this flag only ever adds keys and never removes existing keys.
Freax13
force-pushed
the
tom/workload-owner-key-rename
branch
from
2c54f56 to
db38134
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more obvious to the user that this flag only ever adds keys and never removes existing keys.
This change was made following the discussion in #650 (review).