Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/deployments/just: add e2e, various improvements to just targets #69

Merged
merged 15 commits into from
Jan 18, 2024
Merged

ci/deployments/just: add e2e, various improvements to just targets #69

merged 15 commits into from
Jan 18, 2024

Conversation

katexochen
Copy link
Member

No description provided.

@katexochen katexochen requested a review from 3u13r as a code owner January 17, 2024 15:02
@katexochen katexochen requested a review from malt3 January 17, 2024 15:11
malt3
malt3 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the scripts through shellcheck? They look fine but are complex enough that i'd want so lint them.
Otherwise LGTM!

packages/kypatch.sh Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

.github/workflows/e2e_simple.yml Outdated Show resolved Hide resolved
@katexochen
Copy link
Member Author

Did you run the scripts through shellcheck? They look fine but are complex enough that i'd want so lint them. Otherwise LGTM!

Shellcheck is configured in treefmt.nix, and every script builder in nix will always run shellcheck on the script and refuse to build.

@katexochen
just: fix typo
64f07f4 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
patch-kube-images: init
753fa68 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: patch deployments with image digests
e9fad0b 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
kypatch: a more generic patch-kube-images
69c727c 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: add get-credentials-ci
7528642 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: trap kill
baef80c 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
kypatch: support namespace replacements
009e289 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: patch namespace
66efafe 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: wait for coordinator on set target
f006c00 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: add set and verify to default target
c71aa3f 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: fail on undeploy if namespace exists
0ac2135 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
just: add simple performance indicators for cli
5d05582 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
ci: add simple e2e test
ceacedd 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
e2e-simple: run on pr
e296f83 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen
e2e-simple: allow to skip undeploy for debugging
e2c57d6 
Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen merged commit 3824934 into main Jan 18, 2024
5 checks passed
@katexochen katexochen deleted the p/e2e-simple branch January 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@3u13r 3u13r Awaiting requested review from 3u13r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katexochen @malt3