Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: build static QEMU #702

Merged
merged 1 commit into from
Jul 11, 2024
Merged

nix: build static QEMU #702

merged 1 commit into from
Jul 11, 2024

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Jul 10, 2024

This is based on nixpkgs PRs #30070, #309929, and #314998.

@Freax13 Freax13 requested a review from katexochen as a code owner July 10, 2024 10:06
@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Jul 10, 2024
katexochen
katexochen approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the upstream source of a patch also in a comment where we reference it, including a note if/why it was modified?

Otherwise lgtm, great work!

@Freax13
nix: build static QEMU
ff90999 
This is based on nixpkgs PRs #30070, #309929, and #314998.
@Freax13 Freax13 merged commit 3a20f03 into main Jul 11, 2024
7 checks passed
@Freax13 Freax13 deleted the tom/static-qemu branch July 11, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @katexochen