golangci-lint: add more linters #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
approved these changes
Jul 12, 2024
katexochen
force-pushed
the
p/golangci-more
branch
from
56ed222 to
70c0cd8
Compare
Signed-off-by: Paul Meyer <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
p/golangci-more
branch
from
70c0cd8 to
89cd524
Compare
…tion Signed-off-by: Paul Meyer <[email protected]>
katexochen
force-pushed
the
p/golangci-more
branch
from
89cd524 to
a803753
Compare
katexochen
commented
Jul 12, 2024
Comment on lines
+345
to
+350
| cur, ok := current[p].(map[string]any) | ||
| if !ok || cur == nil { | ||
| cur = make(map[string]any) | ||
| current[p] = cur | ||
| } | ||
| current = current[p].(map[string]any) | ||
| current = cur |
There was a problem hiding this comment.
@burgerdev had to add this non-trivial fix, could you take a look?
burgerdev
approved these changes
Jul 15, 2024
Comment on lines
+345
to
+350
| cur, ok := current[p].(map[string]any) | ||
| if !ok || cur == nil { | ||
| cur = make(map[string]any) | ||
| current[p] = cur | ||
| } | ||
| current = current[p].(map[string]any) | ||
| current = cur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.