Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just: add get-credentials-tdxbm #750

Merged
merged 1 commit into from
Jul 22, 2024
Merged

just: add get-credentials-tdxbm #750

merged 1 commit into from
Jul 22, 2024

Conversation

katexochen
Copy link
Member

No description provided.

@katexochen katexochen requested a review from msanft July 19, 2024 11:37
@katexochen katexochen added the no changelog PRs not listed in the release notes label Jul 19, 2024
@katexochen
Copy link
Member Author

cc @burgerdev

Comment on lines +231 to +233
gcloud secrets versions access \
projects/796962942582/secrets/m50-ganondorf-kubeconf/versions/2 \
--out-file="$tmpConfig"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this in the justfile? It sounds like it should be part of Github Actions or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It enables devs to quickly setup the needed creds, without setting up ssh keys and searching for kube config in other users home directory. Only requirement is to be in the tailnet (should add a command with this requirement).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, this is only useful to a particular group of devs - those who have access to this gcp secret. I simply wonder how much org-specific things we should put into OSS, but feel free to go ahead with it.

justfile Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
justfile Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@katexochen katexochen merged commit 8ee1b41 into main Jul 22, 2024
9 checks passed
@katexochen katexochen deleted the p/tdxbm-creds branch July 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants