rfc: genpolicy on diverse platforms #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1ghtym0
reviewed
Jul 26, 2024
katexochen
approved these changes
Jul 29, 2024
msanft
reviewed
Jul 29, 2024
|
|
||
| ### Bundle both Microsoft's and Kata's tool | ||
|
|
||
| While this approach seems easiest on the surface, it's going to explode the size of the CLI binary, which is already significant. |
There was a problem hiding this comment.
I see the second point, but I think there could be ways around a large CLI (e.g. by sourcing static builds of these tools at runtime, only for the required platform)
Just a note though, not advocating against your proposal
There was a problem hiding this comment.
There's also other drawbacks, like increased TCB etc., but given the other arguments against it I don't think I need to add workarounds to the proposal text.
Co-authored-by: Moritz Sanft <[email protected]> Co-authored-by: Paul Meyer <[email protected]> Co-authored-by: Moritz Eckert <[email protected]>
thomasten
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.