Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourcegen: always use https startup probe for web pod #784

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Aug 2, 2024

The non-service-mesh emojivoto deployment still uses HTTPS and not HTTP. This is implemented in the web container itself.

This fixes the deployment of just default emojivoto in which previously the web pod did not get ready, now it does.

@3u13r 3u13r requested a review from katexochen as a code owner August 2, 2024 14:42
@3u13r 3u13r requested a review from burgerdev August 2, 2024 14:42
@3u13r 3u13r added the no changelog PRs not listed in the release notes label Aug 2, 2024
@3u13r 3u13r merged commit d0d350f into main Aug 5, 2024
9 of 10 checks passed
@3u13r 3u13r deleted the fix/resourcegen/emojivoto-startup-probe branch August 5, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants