e2e: specify multiple reference values in openssl test #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we already have multiple reference values on bare metal? |
msanft
force-pushed
the
msanft/e2e/openssl-multi-validators
branch
from
10d73be to
7eb0c68
Compare
How come? I don't think so. |
katexochen
approved these changes
Aug 16, 2024
We have multiple reference values for baremetal: Milan and Genoa. |
|
See #807 |
Thanks, i missed that. However, adding it for both AKS and bare-metal doesn't hurt, and makes the code a little less dependant on the embedding of multiple reference values being present, which I like |
Freax13
reviewed
Aug 16, 2024
The openssl test now additionally uses multiple reference values to test attestation with multiple validators. Only the second one of the provided validators should successfully validate the attestation document.
msanft
force-pushed
the
msanft/e2e/openssl-multi-validators
branch
from
7eb0c68 to
194fb96
Compare
Freax13
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openssl test now additionally uses multiple reference values to test attestation with multiple validators. Only the second one of the provided validators should successfully validate the attestation document.