atls: only report attestation error if all validators fail #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msanft
reviewed
Aug 16, 2024
There was a problem hiding this comment.
I'm not sure if we really want to pass down a prometheus counter to the attestation functions directly, instead of adding some more generic mechanism to inject code into the validation process (like the callbacks)
As you can see in your change, this results in the CLI side not utilizing the counters at all, having a unused parameter effectively. If we want to pass the counter directly, we should probably have some kind of builder pattern here that allows for adding the counter subsequently, and only using if it it's present.
Previously we reported every single validator error even if there's one validator that passes. This lead to noisy logs and incorrect metrics.
Freax13
force-pushed
the
tom/validator-graceful-fail
branch
from
80ebf3f to
7272598
Compare
msanft
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we reported every single validator error even if there's one validator that passes. This lead to noisy logs and incorrect metrics.