manifest: use tdx validator #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
approved these changes
Aug 26, 2024
CheckRevocations doesn't work without GetCollateral.
The interfaces for trust.HTTPSGetter is different for go-sev-guest and go-tdx-guest. We won't be able to share the same implementation for both of them. Until then we simply won't use a caching getter for TDX.
We don't call any callbacks yet, so the coordinator doesn't work yet, but the set command already succeeds :)
Freax13
force-pushed
the
tom/use-tdx-validator
branch
from
f113bdd to
2423562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary functions to generate validation options for TDX and adds the TDX validators to the list of validators. This is enough to make
setwork.Some caveats/TODOs: