e2e: run release tests on bare metal #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
force-pushed
the
tom/release-test-bm
branch
from
6183d87 to
6499a8e
Compare
katexochen
reviewed
Sep 10, 2024
katexochen
reviewed
Sep 10, 2024
|
Okay, so it looks like the service type LoadBalancer isn't getting an IP in case of the emoji web service as the port is already taken. Therefore, we are using the WaitForService function to get the ClusterIP instead and wait for the pod to become ready (which we do more explicitly in the normal e2e tests, but here through connecting through the service). |
Freax13
force-pushed
the
tom/release-test-bm
branch
from
6499a8e to
6cf2edd
Compare
katexochen
approved these changes
Sep 10, 2024
burgerdev
reviewed
Sep 10, 2024
| # TODO(burgerdev): cli/genpolicy/assets/allow-all.rego is insecure and deliberately omitted | ||
| install -D ${genpolicy.src}/src/kata-opa/allow-all.rego cli/genpolicy/assets/allow-all.rego |
There was a problem hiding this comment.
My intent was that we never package an insecure policy in a released binary. Why do we need to package it now?
There was a problem hiding this comment.
This is only needed to run the tests. This commit will be dropped shortly before merging.
There was a problem hiding this comment.
This commit will be dropped shortly before merging.
Done
Freax13
force-pushed
the
tom/release-test-bm
branch
from
6cf2edd to
84884d7
Compare
burgerdev
approved these changes
Sep 10, 2024
This will make it easier for users to pick the correct hash for their platform.
Freax13
force-pushed
the
tom/release-test-bm
branch
from
84884d7 to
7c0eb5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.