Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use .yml consistently #913

Merged
merged 5 commits into from
Oct 16, 2024
Merged

use .yml consistently #913

merged 5 commits into from
Oct 16, 2024

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Oct 7, 2024

Inspired by #910 (comment)

@Freax13 Freax13 added the no changelog PRs not listed in the release notes label Oct 7, 2024
@Freax13 Freax13 requested a review from katexochen as a code owner October 7, 2024 08:26
Base automatically changed from tom/ci-rework to main October 7, 2024 09:34
@Freax13 Freax13 requested review from burgerdev and 3u13r October 11, 2024 06:26
katexochen
katexochen reviewed Oct 15, 2024
View reviewed changes
packages/scripts.nix Outdated Show resolved Hide resolved
katexochen
katexochen reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm, we should squash those commits.

@Freax13
Copy link
Contributor Author

Freax13 commented Oct 15, 2024

@katexochen I need an approval before I can merge.

The two failing CI jobs are the regression tests with the know nydus-snapshotter issues.

@Freax13 Freax13 merged commit bc20f41 into main Oct 16, 2024
12 of 14 checks passed
@Freax13 Freax13 deleted the tom/yml branch October 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@burgerdev burgerdev Awaiting requested review from burgerdev burgerdev is a code owner

@3u13r 3u13r Awaiting requested review from 3u13r

Assignees
No one assigned
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @katexochen