Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe secure persistent volumes #932

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

burgerdev
Copy link
Contributor

No description provided.

@burgerdev burgerdev requested a review from katexochen as a code owner October 15, 2024 11:55
@burgerdev burgerdev added the documentation Improvements for user docs label Oct 15, 2024
@burgerdev burgerdev force-pushed the burgerdev/docs-storage branch from 37c58ed to a1be10a Compare October 15, 2024 15:55
Copy link

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-17 12:05 UTC

docs/docs/architecture/secrets.md Show resolved Hide resolved
docs/docs/architecture/secrets.md Outdated Show resolved Hide resolved
@burgerdev burgerdev force-pushed the burgerdev/docs-storage branch from b20ac4b to e32c66f Compare October 16, 2024 06:16
Copy link
Member

@m1ghtym0 m1ghtym0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
We're mixing (and probably have been before) workflows into the architecture section.
Maybe we should have a dedicated workflow section as in Constellation at one point?
Not urgent and I'm open to suggestions:-)

@burgerdev
Copy link
Contributor Author

I agree that workflows should not go into the architecture section, but I did not mean to write a workflow here. How about creating follow-up tickets that replace this section with a working example, similar to the Emojivoto-servicemesh experience?

@m1ghtym0
Copy link
Member

Sounds good!

@burgerdev burgerdev merged commit 3ca46cc into main Oct 17, 2024
7 checks passed
@burgerdev burgerdev deleted the burgerdev/docs-storage branch October 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements for user docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants